Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom roles page #30

Merged
merged 9 commits into from
Jul 2, 2024
Merged

Add custom roles page #30

merged 9 commits into from
Jul 2, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 18, 2024

This PR adds a page under https://www.elastic.co/docs/current/serverless/project-settings for the new Custom Roles app.

A subsequent PR will contain the related changes to https://www.elastic.co/docs/current/serverless/general/assign-user-roles

NOTE: The content of the page is not visible in the preview since the serverlessCustomRoles variable is currently set to false.

Preview

@elasticdocs
Copy link
Collaborator

elasticdocs commented Jun 19, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@lcawl lcawl marked this pull request as ready for review June 19, 2024 19:02
@lcawl lcawl requested a review from a team as a code owner June 19, 2024 19:02
@lcawl lcawl requested a review from legrego June 19, 2024 19:44
Copy link
Contributor

@alxchalkias alxchalkias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the Cloud side

jeramysoucy
jeramysoucy previously approved these changes Jul 2, 2024
Copy link
Contributor

@jeramysoucy jeramysoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay on reviewing this one. It slipped through the cracks. I just had a few suggestions, but nothing major. Looks good!

serverless/pages/custom-roles.mdx Outdated Show resolved Hide resolved
serverless/pages/custom-roles.mdx Outdated Show resolved Hide resolved
serverless/pages/custom-roles.mdx Show resolved Hide resolved
serverless/pages/custom-roles.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎸

@lcawl lcawl merged commit 4fc4d12 into elastic:main Jul 2, 2024
2 checks passed
@lcawl lcawl deleted the custom-roles branch July 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants